Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readline and shared build for mingw -- WIP DNM #1158

Closed
wants to merge 1 commit into from

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Oct 24, 2022

  1. Add readline dependancy
  2. Use dynamic link in order to avoid readline MSYS2 issue
    Multiple definitions of symbol PC when statically linking readline and termcap into a program msys2/MINGW-packages#8105

This is probably not the right fix. Please DO NOT MERGE now.

Reference:

1) Add readline dependancy
2) Use dynamic link in order to avoid readline MSYS2 issue
@mcuee mcuee changed the title Add readline and shared build for mingw Add readline and shared build for mingw -- WIP DNM Oct 24, 2022
@mcuee mcuee added the enhancement New feature or request label Oct 24, 2022
@mcuee
Copy link
Collaborator Author

mcuee commented Oct 27, 2022

This is not the right fix and I will close this one.

@mcuee mcuee closed this Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant